From eac3f5122fd4769b2885d8ad78bcbcf5df2472c1 Mon Sep 17 00:00:00 2001 From: Olaf Hering Date: Wed, 1 Oct 2014 18:41:04 +0200 Subject: [PATCH] tools/hotplug: fix race during xen.conf creation A make -j8 will call the xen.conf rule twice. The move-if-changed macro may fail if the tmp file was already removed by the other make process. Fix this by let the all target depend on install. Also remove the generated file with make clean. Signed-off-by: Olaf Hering Acked-by: Ian Campbell Cc: Ian Jackson Cc: Stefano Stabellini Cc: Ian Campbell Cc: Wei Liu [ ijc -- fixed s/of/if/ typo in commit message ] --- tools/hotplug/Linux/systemd/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/hotplug/Linux/systemd/Makefile b/tools/hotplug/Linux/systemd/Makefile index dc98b67367..90ba16e0f2 100644 --- a/tools/hotplug/Linux/systemd/Makefile +++ b/tools/hotplug/Linux/systemd/Makefile @@ -21,10 +21,11 @@ ALL_XEN_SYSTEMD = $(XEN_SYSTEMD_MODULES) \ $(XEN_SYSTEMD_SERVICE) .PHONY: all -all: $(ALL_XEN_SYSTEMD) +all: install .PHONY: clean clean: + rm -f $(ALL_XEN_SYSTEMD) .PHONY: install install: $(ALL_XEN_SYSTEMD) -- 2.30.2